{"user_signed_in":false,"allow_comments":true,"is_author":false,"request":{"endpoint":"https://exercism.org/api/v2/tracks/ruby/exercises/leap/community_solutions/PackMan97/comments","options":{"initial_data":{"items":[{"uuid":"3c1e3f2e-08d3-11ec-81c5-853579c25f94","author":{"handle":"charger","avatar_url":"https://assets.exercism.org/avatars/8851/0","flair":null,"reputation":"11"},"content_markdown":"I think previous solution was more readable, but not need make 3 methods. You just can make 3 variables in self.leap?. In result method will be contain 4 rows, but names of this variables will be like a good comments.","content_html":"

I think previous solution was more readable, but not need make 3 methods. You just can make 3 variables in self.leap?. In result method will be contain 4 rows, but names of this variables will be like a good comments.

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c1e3fc4-08d3-11ec-81c5-853579c25f94","author":{"handle":"ankhers","avatar_url":"https://assets.exercism.org/avatars/8004/0","flair":null,"reputation":"87"},"content_markdown":"I certainly like the fact that 4 is the main focus of the boolean. I feel that is the main idea behind a leap year. However, with it being the way it currently is, it is a little hard to read. You are checking to see if the given year is divisible by some number, or in the case of 100, that it is not divisible by it. Forcing me to do a double take for each of them to see if you are checking == or !=. I think this could read a little better if you did something similar to your original solution. Maybe if you had a single divisible_by? method. I believe that would greatly increase readability.","content_html":"

I certainly like the fact that 4 is the main focus of the boolean. I feel that is the main idea behind a leap year.

However, with it being the way it currently is, it is a little hard to read. You are checking to see if the given year is divisible by some number, or in the case of 100, that it is not divisible by it. Forcing me to do a double take for each of them to see if you are checking == or !=.

I think this could read a little better if you did something similar to your original solution. Maybe if you had a single divisible_by? method. I believe that would greatly increase readability.

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c1e40e6-08d3-11ec-81c5-853579c25f94","author":{"handle":"PackMan97","avatar_url":"https://assets.exercism.org/avatars/10376/0","flair":null,"reputation":"25"},"content_markdown":"In my previous iteration, I was trying too hard. This is a single line function. Using mod == 0 is a well known check for divisible by and a well placed comment makes it clear the intent of the conditional. I think the lesson of this exercise is to tempt one into over engineering a solution.","content_html":"

In my previous iteration, I was trying too hard. This is a single line function. Using mod == 0 is a well known check for divisible by and a well placed comment makes it clear the intent of the conditional.

I think the lesson of this exercise is to tempt one into over engineering a solution.

","updated_at":"2018-07-13T10:01:29Z","links":{}}]}}},"links":{"create":"https://exercism.org/api/v2/tracks/ruby/exercises/leap/community_solutions/PackMan97/comments","enable":"https://exercism.org/api/v2/tracks/ruby/exercises/leap/community_solutions/PackMan97/comments/enable","disable":"https://exercism.org/api/v2/tracks/ruby/exercises/leap/community_solutions/PackMan97/comments/disable"}}

Language Tracks

#48in24 Challenge

Your Journey

Exercism Perks

Community Videos

Brief Introduction Series

Interviews & Stories

Discord

Forum

Getting started

Mentoring

Docs

Contributors

Donate

About Exercism

Our Impact

Insiders

SWAG

PackMan97's solution 25 to Leap in Ruby

About the Ruby Exercise

Other solutions to Leap in Ruby

PackMan97's solution
25

to Leap in Ruby

Other solutions to Leap
in

Ruby