{"user_signed_in":false,"allow_comments":true,"is_author":false,"request":{"endpoint":"https://exercism.org/api/v2/tracks/ruby/exercises/leap/community_solutions/nicolai86/comments","options":{"initial_data":{"items":[{"uuid":"3c1af26a-08d3-11ec-81c5-853579c25f94","author":{"handle":"ankhers","avatar_url":"https://assets.exercism.org/avatars/8004/0","flair":null,"reputation":"87"},"content_markdown":"@tasassce When I did this exercise, I was given a test suite that had an instance method and not a class method. Also note that this was submitted 9 weeks ago. If you want, checkout my solution to this exercise, the linked test suite is still the current one with a class method. The linked test suite is either always the most recent one, or because that feature (links to the test suite) was not implemented at the start, they just link the most recent ones because there is no real way of knowing which version of the tests someone had.","content_html":"

@tasassce When I did this exercise, I was given a test suite that had an instance method and not a class method. Also note that this was submitted 9 weeks ago. If you want, checkout my solution to this exercise, the linked test suite is still the current one with a class method.

The linked test suite is either always the most recent one, or because that feature (links to the test suite) was not implemented at the start, they just link the most recent ones because there is no real way of knowing which version of the tests someone had.

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c1af36e-08d3-11ec-81c5-853579c25f94","author":{"handle":"tadassce","avatar_url":"https://assets.exercism.org/avatars/5554/0","flair":null,"reputation":"32"},"content_markdown":"@woodjk I'm not comparing with my personal test suite, but there's a link to the Test Suite just above the code here on the left and the code doesn't pass those. By the way, how do you know he was given different ones? The tasks and the test suites are the same.","content_html":"

@woodjk I'm not comparing with my personal test suite, but there's a link to the Test Suite just above the code here on the left and the code doesn't pass those. By the way, how do you know he was given different ones? The tasks and the test suites are the same.

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c1af3e6-08d3-11ec-81c5-853579c25f94","author":{"handle":"ankhers","avatar_url":"https://assets.exercism.org/avatars/8004/0","flair":null,"reputation":"87"},"content_markdown":"Meta Nit @tadassce, the tests have changed. Thus the solution has changed. @nicolai86 had been given a different set of tests than you had. Don't assume that because you received one set of tests that everyone else has the same set. Things are being added / removed / modified as time goes on. Please keep this in mind when making comments.","content_html":"

Meta Nit

@tadassce, the tests have changed. Thus the solution has changed. @nicolai86 had been given a different set of tests than you had. Don't assume that because you received one set of tests that everyone else has the same set.

Things are being added / removed / modified as time goes on. Please keep this in mind when making comments.

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c1af4d6-08d3-11ec-81c5-853579c25f94","author":{"handle":"bryanaknight","avatar_url":"https://assets.exercism.org/avatars/5428/0","flair":null,"reputation":"31"},"content_markdown":"Because you have the attr_reader, you don't need line 4 and you don't need to pass year as an argument to the leap method either. It will know what year is inside the method because of the attr.","content_html":"

Because you have the attr_reader, you don't need line 4 and you don't need to pass year as an argument to the leap method either. It will know what year is inside the method because of the attr.

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c1af54e-08d3-11ec-81c5-853579c25f94","author":{"handle":"michaelavila","avatar_url":"https://assets.exercism.org/avatars/1864/0","flair":null,"reputation":"762"},"content_markdown":"I like this and adapted some of the ideas in my own implementation. I don't understand why you're storing the year on initialization though? It would all work if you just defined leap? as def leap?(year)? Since the three expressions are written out well it might be worth including a comment with a link to the leap year calculation.","content_html":"

I like this and adapted some of the ideas in my own implementation. I don't understand why you're storing the year on initialization though? It would all work if you just defined leap? as def leap?(year)?

Since the three expressions are written out well it might be worth including a comment with a link to the leap year calculation.

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c1af5bc-08d3-11ec-81c5-853579c25f94","author":{"handle":"tadassce","avatar_url":"https://assets.exercism.org/avatars/5554/0","flair":null,"reputation":"32"},"content_markdown":"I assume you changed your test file as well, but the given tests don't pass since you're expected to have a class method leap? and you only have an instance method","content_html":"

I assume you changed your test file as well, but the given tests don't pass since you're expected to have a class method leap? and you only have an instance method

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c1af6b6-08d3-11ec-81c5-853579c25f94","author":{"handle":"GregBaugues","avatar_url":"https://assets.exercism.org/avatars/11188/0","flair":null,"reputation":"25"},"content_markdown":"I like the use of the zero? method. How about extracting a method that performs the modulus operation and the comparison... say .divisible? It will save you from having to create three temporary variables.","content_html":"

I like the use of the zero? method.

How about extracting a method that performs the modulus operation and the comparison... say .divisible? It will save you from having to create three temporary variables.

","updated_at":"2018-07-13T10:01:29Z","links":{}}]}}},"links":{"create":"https://exercism.org/api/v2/tracks/ruby/exercises/leap/community_solutions/nicolai86/comments","enable":"https://exercism.org/api/v2/tracks/ruby/exercises/leap/community_solutions/nicolai86/comments/enable","disable":"https://exercism.org/api/v2/tracks/ruby/exercises/leap/community_solutions/nicolai86/comments/disable"}}

Language Tracks

#48in24 Challenge

Your Journey

Exercism Perks

Community Videos

Brief Introduction Series

Interviews & Stories

Discord

Forum

Getting started

Mentoring

Docs

Contributors

Donate

About Exercism

Our Impact

Insiders

SWAG

nicolai86's solution 24 to Leap in Ruby

About the Ruby Exercise

Other solutions to Leap in Ruby

nicolai86's solution
24

to Leap in Ruby

Other solutions to Leap
in

Ruby