{"user_signed_in":false,"allow_comments":true,"is_author":false,"request":{"endpoint":"https://exercism.org/api/v2/tracks/ruby/exercises/say/community_solutions/vkwong/comments","options":{"initial_data":{"items":[{"uuid":"3c56bbe2-08d3-11ec-81c5-853579c25f94","author":{"handle":"pazatico","avatar_url":"https://assets.exercism.org/avatars/101718/0","flair":null,"reputation":"103"},"content_markdown":"Sorry to interfere here, but I have the same circular dependency problem with my submission. I am unable to say whether it would be better to call .in_english on a new instance of Say. What would be the difference?","content_html":"

Sorry to interfere here, but I have the same circular dependency problem with my submission. I am unable to say whether it would be better to call .in_english on a new instance of Say. What would be the difference?

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c56bcb4-08d3-11ec-81c5-853579c25f94","author":{"handle":"pazatico","avatar_url":"https://assets.exercism.org/avatars/101718/0","flair":null,"reputation":"103"},"content_markdown":"I'll try but here recursion seems so obvious that it's hard for me to imagine what may looks like an iterative solution.","content_html":"

I'll try but here recursion seems so obvious that it's hard for me to imagine what may looks like an iterative solution.

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c56bd36-08d3-11ec-81c5-853579c25f94","author":{"handle":"kytrinyx","avatar_url":"https://assets.exercism.org/avatars/6/0","flair":null,"reputation":"86.5k"},"content_markdown":"Think about how you do it in your head when you do the conversion. You don't do it recursively, is my guess.","content_html":"

Think about how you do it in your head when you do the conversion. You don't do it recursively, is my guess.

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c56bda4-08d3-11ec-81c5-853579c25f94","author":{"handle":"kytrinyx","avatar_url":"https://assets.exercism.org/avatars/6/0","flair":null,"reputation":"86.5k"},"content_markdown":"In Ruby it's fairly common to treat object creation as free--until you actually have a benchmark that says that it's costing you too much in performance. So you could do that. The other approach would be to solve the problem iteratively (using a loop).","content_html":"

In Ruby it's fairly common to treat object creation as free--until you actually have a benchmark that says that it's costing you too much in performance. So you could do that. The other approach would be to solve the problem iteratively (using a loop).

","updated_at":"2018-07-13T10:01:29Z","links":{}},{"uuid":"3c56be76-08d3-11ec-81c5-853579c25f94","author":{"handle":"kytrinyx","avatar_url":"https://assets.exercism.org/avatars/6/0","flair":null,"reputation":"86.5k"},"content_markdown":"I like the clarity of your constants. They're very easy to scan, and the lookups will be very effective. Did you consider using arrays for these? If so, what were the trade-offs that you considered? For the argument error, I'd love to see a message telling me what I'm doing wrong and/or how to get it right. When I run into errors that tell me I'm doing it wrong without telling me how, I always find myself frustrated, hunting around, and reading code trying to figure out what they're expecting, kind of like being punished when nobody told you the rules. I'm not sure that number_to_words is paying it's way in terms of abstractions. What if you inlined the contents of number_to_words into in_english? There's a bit of recursion here, though it's quite hard to spot--the circular dependency between decompose_number_to_words and number_to_words is a little bit mind-bending. Did you consider an iterative approach to this? If so, what did you like/not like about it?","content_html":"

I like the clarity of your constants. They're very easy to scan, and the lookups will be very effective. Did you consider using arrays for these? If so, what were the trade-offs that you considered?

For the argument error, I'd love to see a message telling me what I'm doing wrong and/or how to get it right. When I run into errors that tell me I'm doing it wrong without telling me how, I always find myself frustrated, hunting around, and reading code trying to figure out what they're expecting, kind of like being punished when nobody told you the rules.

I'm not sure that number_to_words is paying it's way in terms of abstractions. What if you inlined the contents of number_to_words into in_english?

There's a bit of recursion here, though it's quite hard to spot--the circular dependency between decompose_number_to_words and number_to_words is a little bit mind-bending. Did you consider an iterative approach to this? If so, what did you like/not like about it?

","updated_at":"2018-07-13T10:01:29Z","links":{}}]}}},"links":{"create":"https://exercism.org/api/v2/tracks/ruby/exercises/say/community_solutions/vkwong/comments","enable":"https://exercism.org/api/v2/tracks/ruby/exercises/say/community_solutions/vkwong/comments/enable","disable":"https://exercism.org/api/v2/tracks/ruby/exercises/say/community_solutions/vkwong/comments/disable"}}

Language Tracks

#48in24 Challenge

Your Journey

Exercism Perks

Community Videos

Brief Introduction Series

Interviews & Stories

Discord

Forum

Getting started

Mentoring

Docs

Contributors

Donate

About Exercism

Our Impact

Insiders

SWAG

vkwong's solution 60 to Say in Ruby

About the Ruby Exercise

Other solutions to Say in Ruby

vkwong's solution
60

to Say in Ruby

Other solutions to Say
in

Ruby